Implement periodic transform #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@molet this is ready for a review if you're up for it. |
devmotion
reviewed
Sep 22, 2020
devmotion
reviewed
Sep 22, 2020
theogf
reviewed
Sep 22, 2020
molet
reviewed
Sep 22, 2020
molet
reviewed
Sep 22, 2020
Co-authored-by: Letif Mones <[email protected]>
|
AFAICT everyone is now happy with this PR. Subject to approval, I can go ahead and merge -- testing will improve once #159 is available. |
molet
approved these changes
Sep 23, 2020
devmotion
approved these changes
Sep 23, 2020
|
Bump the version number I guess? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to periodicise kernels other than the EQ.
Note that the exact translation from this transformation (which does the canonical thing) and the periodic EQ is a bit convoluted. See #172 for discussion.