Improve testing #182
Merged
Improve testing #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These failures are weird, and I'm really struggling to reproduce them locally. Not really sure what's going on :grimace: edit: I was looking at the wrong kernel... |
|
Tests now pass. This is ready for review. CI drop is related to test utils. |
devmotion
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of a lot more data points during testing, which makes the tests somewhat harder to pass.
However, it also relaxes some tolerances for specific kernels that appear to struggle for accuracy. For example, the exponential kernel appears to be fairly inaccurate, so the tolerance has been relaxed a bit there.
The extra data points highlighted that the
Gaborkernel cannot be used in conjunction with multi-dimensional inputs, which is something that we were previously doing in our tests. That has now been resolved.@sharanry if possible, could you see if this fixes your problem, or are you only seeing test failures in CI?