Skip to content

CompatHelper: bump compat for "Distances" to "0.10" #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 9, 2020

This pull request changes the compat entry for the Distances package from 0.9.1 to 0.9.1, 0.10.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm actually not sure what bit of 0.10 broke 0.9, but nvm :)

@devmotion
Copy link
Member

LGTM. I'm actually not sure what bit of 0.10 broke 0.9, but nvm :)

The type parameters of (Sq)Mahalanobis changed, before it was the element type of the wrapped matrix but now it is the type of the matrix. BTW now (Sq)Mahalanobis supports any AbstractMatrix - we never checked that the matrix that we use for SqMahalanobis is a Matrix and already allowed an AbstractMatrix on our side, so this resolves a (potential) bug in KernelFunctions.

@devmotion devmotion merged commit 1e5751e into master Oct 9, 2020
@devmotion devmotion deleted the compathelper/new_version/2020-10-09-00-32-44-776-3843470878 branch October 9, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants