Added CI/docs to Github actions #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Nov 23, 2020
devmotion
reviewed
Nov 23, 2020
Co-authored-by: David Widmann <[email protected]>
|
@devmotion Do you know why it's triggered by both push and pull_request? |
|
You pushed to a branch in the repo and opened a pull request, so that's expected 😄 Probably you only want to run CI tests if something is pushed to master or a pull request is opened. I added a suggestion that achieves this. |
devmotion
reviewed
Nov 24, 2020
Co-authored-by: David Widmann <[email protected]>
|
Ah one thing I missed: I guess it would be good to delete |
|
Ah wait it's actually deleted 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a starting point to reproduce the current behavior of Travis