Cancel previous running workflows on push #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't seem like it ran, did it? |
|
IIRC this type of actions always uses the version on master for security reasons. It doesn't exist currently so it's not run. |
|
It is mentioned in the documentation:
|
|
Of course, this makes it difficult to assess if the action works properly here 😄 @willtebbutt @theogf What do you think, should we just try it and see if it works and possibly fix it in follow-up PRs? |
|
Go for it! |
|
It seems to be at least somewhat correct and working: https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/actions/runs/897590843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just learnt about https://github.com/styfle/cancel-workflow-action from JuliaDiff/ChainRules.jl#426. Seems this could solve #281.
I followed the instructions in https://github.com/styfle/cancel-workflow-action#advanced-pull-requests-from-forks which should also work for PRs from forks.