Skip to content

Bump ChainRulesCore #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Bump ChainRulesCore #293

merged 2 commits into from
Jun 2, 2021

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Jun 2, 2021

ChainRulesCore made some breaking changes that effect us -- this patch restricts the ChainRulesCore version a bit, and fixes these deprecations.

Anyone should feel free to review. @rossviljoen @4aHxKzD if you're interested.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there are some things that could possibly be improved with InplaceableThunks but that's work for future PRs 🙂

@willtebbutt willtebbutt merged commit ad95cd0 into master Jun 2, 2021
@willtebbutt willtebbutt deleted the wct/bump-chain-rules-core branch June 2, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants