Skip to content

Fix Manifest for GP prior example #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Fix Manifest for GP prior example #340

merged 5 commits into from
Jul 20, 2021

Conversation

willtebbutt
Copy link
Member

As discussed in #339

@willtebbutt willtebbutt requested a review from st-- July 19, 2021 13:02
@willtebbutt
Copy link
Member Author

willtebbutt commented Jul 19, 2021

Test failure is unrelated to this PR. Not sure what's causing it, but it's a separate issue.

theogf
theogf previously approved these changes Jul 19, 2021
@willtebbutt
Copy link
Member Author

Hmm I don't appear to be able to merge. Possibly because the FBM kernel AD tests are being annoying?

st--
st-- previously approved these changes Jul 19, 2021
@st--
Copy link
Member

st-- commented Jul 19, 2021

@willtebbutt we should also update the examples/README.md instructions for adding new examples, do you want to just add that in here ?

@willtebbutt willtebbutt dismissed stale reviews from st-- and theogf via 5863425 July 20, 2021 21:02
@willtebbutt willtebbutt requested a review from st-- July 20, 2021 21:03
@willtebbutt willtebbutt merged commit ef022e3 into master Jul 20, 2021
@willtebbutt willtebbutt deleted the wct/examples-dev branch July 20, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants