Skip to content

Adding vcat and tests #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomasgudjonwright
Copy link
Member

Closes #348.

Not sure if we want to default to a specific type of the two inputs are different, or error as I have done at this point.

@willtebbutt
Copy link
Member

Not sure if we want to default to a specific type of the two inputs are different, or error as I have done at this point.

I suspect that we just want two methods here -- one for each isotopic type. The reason being that vcat is defined for both of them via a fallback definition -- we just want to accelerate it in cases where it's possible to accelerate.

@thomasgudjonwright
Copy link
Member Author

Not sure if we want to default to a specific type of the two inputs are different, or error as I have done at this point.

I suspect that we just want two methods here -- one for each isotopic type. The reason being that vcat is defined for both of them via a fallback definition -- we just want to accelerate it in cases where it's possible to accelerate.

Ahh okay and then just let it error by itself if someone tries to pass it one of each type as the inputs?

@willtebbutt
Copy link
Member

Ahh okay and then just let it error by itself if someone tries to pass it one of each type as the inputs?

Not quite -- it'll hit the slow fallback method, and produce a valid result, it will just do it slowly.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a patch bump.

@thomasgudjonwright thomasgudjonwright merged commit 7286dd5 into JuliaGaussianProcesses:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Base.vcat method to MO input types
2 participants