Heterotopic MO kernel helper #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@thomasgudjonwright if there's nothing else, would you mind approving? |
thomasgudjonwright
approved these changes
Aug 12, 2021
|
Patch bumped. Will merge when CI passes again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I like this feature. It's a bit trivial at the minute, but I think it probably helps a bit with the cognitive load of using multi-output kernels in a heterotopic setting.
If nothing else, suggesting that users use this function to get their multi-output data in a format that KernelFunctions likes will help to future proof us a bit in case we change implementation details later on (e.g. maybe using
StructArrays to represent the inputs that are returned from this function)