-
Notifications
You must be signed in to change notification settings - Fork 36
Update README #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update README #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The priorities seemed a bit out of date and, given that we don't really have a super-coherant list of priorities for this package at the minute, I figured it best to remove them for now. In their place I propose a related work section.
st--
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible!
Would you want to keep a note that KernelFunctions is and will be AD-compatible though?
Good point. Yes, I want that. |
st--
reviewed
Sep 29, 2021
st--
reviewed
Sep 29, 2021
Co-authored-by: st-- <[email protected]>
Co-authored-by: st-- <[email protected]>
theogf
approved these changes
Sep 29, 2021
Co-authored-by: Théo Galy-Fajou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The priorities seemed a bit out of date and, given that we don't really have a coherant list of priorities for this package at the minute, I figured it best to remove them for now.
In their place I propose a related work section.
Proposed changes
What alternatives have you considered?
Trying to update the priorities to reflect where we are today. This turned out not to be possible, owing to a lack of a clear set of priorities.
Breaking changes
None