Use Iterators.peel, reduce allocations, and add missing kernelmatrix_diag! definitions + tests
#379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not know about |
theogf
approved these changes
Oct 8, 2021
devmotion
commented
Oct 8, 2021
|
|
||
| function validate_inplace_dims(K::AbstractVector, x::AbstractVector) | ||
| if length(K) != length(x) | ||
| function validate_inplace_dims(K::AbstractVector, x::AbstractVector, y::AbstractVector) |
There was a problem hiding this comment.
The version for two inputs was missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started with a small improvement (replace
first+Iterators.dropwithIterators.peel) but lead to some more changes in the end 😄 So taken together, this PRfirst+Iterators.dropwithIterators.peelkernelmatrix!andkernelmatrix_diag!functions ofKernelTensorProductfor > 2 kernels (allocations are the same for 2 kernels and are increased for 1 kernel, but in the latter case one should not construct aKernelTensorProductin the first place)kernelmatrix_diag!forKernelTensorProductand a test for it totest_interfacekernelmatrix_diag!forScaledKernel(a quick check revealed it was missing, maybe more kernels have to be fixed for tests to pass)