Skip to content

Try to switch to CodeCov #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Try to switch to CodeCov #381

merged 6 commits into from
Oct 25, 2021

Conversation

theogf
Copy link
Member

@theogf theogf commented Oct 8, 2021

Summary
The integration of Coveralls is a bit annoying (need to add a Bot as a collaborator). Also it would be better to use the same coverage processing with all repos.
Proposed changes
Move from Coveralls to CodeCov

What alternatives have you considered?
Adding Coveralls bot as a member

Breaking changes
None

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@7ce1c39). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #381   +/-   ##
=========================================
  Coverage          ?   89.23%           
=========================================
  Files             ?       52           
  Lines             ?     1198           
  Branches          ?        0           
=========================================
  Hits              ?     1069           
  Misses            ?      129           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce1c39...234340a. Read the comment docs.

@devmotion
Copy link
Member

I think it's fine, mainly also because it simplifies the CI setup (I don't think the app installation is problematic). It seems the reported coverage is lower than the one reported by coveralls?

@theogf
Copy link
Member Author

theogf commented Oct 8, 2021

Yep I think it's because of the parallelization of our tests

@theogf
Copy link
Member Author

theogf commented Oct 8, 2021

Looking into this, it looks like CodeCov and Coveralls count the lines differently, it's a bit odd...

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@theogf
Copy link
Member Author

theogf commented Oct 25, 2021

"Others" failing because of JuliaStats/Distances.jl#221 (try/catch not compatible with Zygote)

@devmotion what should I do here? Should I comment out the tests with SqMahalonobis?

@devmotion
Copy link
Member

Maybe just upper bound Distances in test/Project.toml and open an issue so we don't forget to remove the bound once the problem is fixed upstream?

Co-authored-by: David Widmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants