CompatHelper: bump compat for Distances to 0.10 for package test, (keep existing compat) #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ep existing compat)
theogf
force-pushed
the
compathelper/new_version/2021-10-26-00-42-21-941-03135690217
branch
from
757dfe9 to
a6e2264
Compare
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 52 52
Lines 1199 1199
=======================================
Hits 1112 1112
Misses 87 87 Continue to review full report at Codecov.
|
|
Blocked by #390 |
…21-941-03135690217
Tests still fail. In any case, the compat line does not make sense. |
Merged
st--
deleted the
compathelper/new_version/2021-10-26-00-42-21-941-03135690217
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Distancespackage from= 0.10.0, = 0.10.1, = 0.10.2, = 0.10.3, = 0.10.4to= 0.10.0, = 0.10.1, = 0.10.2, = 0.10.3, = 0.10.4, 0.10for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.