AD Performance #467
Merged
AD Performance #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 93.09% 93.70% +0.61%
==========================================
Files 52 52
Lines 1275 1351 +76
==========================================
+ Hits 1187 1266 +79
+ Misses 88 85 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
August 22, 2022 17:22
Co-authored-by: Théo Galy-Fajou <[email protected]>
theogf
approved these changes
Aug 23, 2022
|
Don't forget to bump the version. |
devmotion
reviewed
Aug 23, 2022
devmotion
reviewed
Aug 23, 2022
devmotion
reviewed
Aug 23, 2022
devmotion
reviewed
Aug 23, 2022
devmotion
reviewed
Aug 25, 2022
devmotion
reviewed
Aug 25, 2022
devmotion
reviewed
Aug 25, 2022
devmotion
reviewed
Aug 25, 2022
|
@devmotion thanks for the careful review -- I believe I've resolved everything that you discussed |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
All CI appears to be passing at last! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extends work from #466 to many (nearly all) of our kernels. Identifies various performance bugs in the process, and fixes many of them.
Proposed changes
Introduces the
test_interface_ad_perffunction intest/test_utils.jl. This utilises the allocations-invariant-to-input-size heuristic to check performance.What alternatives have you considered?
N/A
Breaking changes
None