-
Notifications
You must be signed in to change notification settings - Fork 36
Extend lengthscale tip #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/src/userguide.md
Outdated
Per-dimension lengthscales for automatic relevance determination work in a similar manner: | ||
```julia | ||
inverse_length_scales = [1.0, 2.0] | ||
k = SqExponentialKernel() ∘ ARDTransform(inverse_length_scales) | ||
k = compose(SqExponentialKernel(), ARDTransform(inverse_length_scales)) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought commonly one would just use with_lengthscale
? ARD is actually mentioned two lines above 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. I hadn't realised that is a thing! Maybe I should just add an example with a vector of lengthscales to the tip then, rather than extending substantially? And maybe change the title to "How do I set the lengthscale(s)?"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are good suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tweaked -- let me know if you think it works.
Codecov ReportBase: 40.97% // Head: 47.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 40.97% 47.94% +6.97%
==========================================
Files 52 52
Lines 1340 1341 +1
==========================================
+ Hits 549 643 +94
+ Misses 791 698 -93
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Summary
It was unclear to a Stheno.jl user how to do ARD stuff -- see this issue. This PR extends our lengthscale tip to multiple dimensions.
Proposed changes
Extend lengthscale tip to cover ARD and factor analysis cases.
What alternatives have you considered?
I considered adding something in Stheno, but I didn't want to dilute the docs.
I also considered not adding the factor analyis example, since it is so closely-related to the ARD example, it felt important to include.
Breaking changes
None