Ensure accepted input types are general where possible #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 68.81% // Head: 79.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
===========================================
+ Coverage 68.81% 79.54% +10.72%
===========================================
Files 52 52
Lines 1347 1354 +7
===========================================
+ Hits 927 1077 +150
+ Misses 420 277 -143
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
willtebbutt
changed the title
devmotion
reviewed
Oct 10, 2022
Co-authored-by: David Widmann <[email protected]>
…com/JuliaGaussianProcesses/KernelFunctions.jl into wct/generalise-accepted-input-types
devmotion
approved these changes
Oct 10, 2022
theogf
approved these changes
Oct 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #479 , some of our kernels / transforms etc is overly strict in terms of the types that it accepts, prompting users to find workaround. The goal of this is to resolve these problems and add some tests to prevent regression.
Proposed changes
What alternatives have you considered?
N/A
Breaking changes
N/A