Skip to content

Remove unused type parameter #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Remove unused type parameter #482

merged 2 commits into from
Oct 17, 2022

Conversation

devmotion
Copy link
Member

Should fix #481 (comment).

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 58.66% // Head: 64.59% // Increases project coverage by +5.93% 🎉

Coverage data is based on head (323782a) compared to base (46fa287).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   58.66%   64.59%   +5.93%     
==========================================
  Files          52       52              
  Lines        1345     1350       +5     
==========================================
+ Hits          789      872      +83     
+ Misses        556      478      -78     
Impacted Files Coverage Δ
src/distances/sinus.jl 63.63% <100.00%> (ø)
src/generic.jl 40.00% <0.00%> (+20.00%) ⬆️
src/transform/periodic_transform.jl 40.00% <0.00%> (+40.00%) ⬆️
src/transform/lineartransform.jl 100.00% <0.00%> (+45.45%) ⬆️
src/transform/scaletransform.jl 100.00% <0.00%> (+60.00%) ⬆️
src/transform/transform.jl 100.00% <0.00%> (+80.00%) ⬆️
src/transform/chaintransform.jl 80.00% <0.00%> (+80.00%) ⬆️
src/transform/selecttransform.jl 90.90% <0.00%> (+90.90%) ⬆️
src/transform/functiontransform.jl 92.30% <0.00%> (+92.30%) ⬆️
src/transform/ardtransform.jl 93.33% <0.00%> (+93.33%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion devmotion merged commit eac3538 into master Oct 17, 2022
@devmotion devmotion deleted the dw/unbound_args branch October 17, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguities
3 participants