CompatHelper: bump compat for IrrationalConstants to 0.2, (keep existing compat) #491
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
theogf
force-pushed
the
compathelper/new_version/2023-02-21-01-09-15-337-00122106565
branch
from
6b57e35 to
b4fb67e
Compare
Codecov ReportBase: 94.25% // Head: 94.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 52 52
Lines 1374 1374
=======================================
Hits 1295 1295
Misses 79 79 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Do not merge yet -- IrrationalConstants being held back by something. Am investigating |
|
Appears to update locally. Closed + re-opened to re-run CI. |
|
Needs SpecialFunctions, StatsFuns, etc. I assume we might depend on one of these. |
|
Yup. Looks like it's SpecialFunctions. Looks like it's compatible with version 1 of SpecialFunctions, but not 2. Looks like you've already opened the relevant PR, so we'll just have to wait for that to be merged |
|
Version 0.2 of IrrationalConstants is now being used in CI. Will merge when CI passes |
|
Are you sure? https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/actions/runs/4242302919/jobs/7373628447#step:6:96 seems to indicate it still uses IrrationalConstants 0.1 (not too surprised since e.g. StatsFuns and DiffRules are not updated yet). |
|
Ahhh I didn't look far enough through the logs -- looks like 0.2 is getting installed, then downgraded to 0.1. Good catch |
|
The possibly last missing package should be ChainRules. I already released updates of SpecialFunctions, StatsFuns, and DiffRules. The ChainRules PR had quite a few test failures but all of them should be unrelated. |
There was a problem hiding this comment.
Seems to actually test IrrationalConstants 0.2 now: https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/actions/runs/4250443333/jobs/7394308795#step:6:96 🎉
|
We appear to have sporadic test failures for the FBM kernel -- this is presumably a tricky numerical issue. I've loosened the tolerance in the hope that tests will all pass. Will merge if they do. |
willtebbutt
deleted the
compathelper/new_version/2023-02-21-01-09-15-337-00122106565
branch
This pull request changes the compat entry for the
IrrationalConstantspackage from0.1to0.1, 0.2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.