Skip to content

Remove chainrule and test for SqMahalanobis #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

simsurace
Copy link
Member

@simsurace simsurace commented Nov 11, 2023

Just some cleanup work to remove remnants of the Mahalanobis kernel which has been absent for a while.

  • They are no longer needed
  • The chainrule is committing type piracy towards Distances.jl (would there be value to move the rule in the extension there?)
  • The test is triggering some warnings that are distracting

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec19a94) 90.43% compared to head (a8d07c5) 90.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   90.43%   90.34%   -0.09%     
==========================================
  Files          52       52              
  Lines        1390     1378      -12     
==========================================
- Hits         1257     1245      -12     
  Misses        133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to patch bump, so that we can tag a release

@simsurace
Copy link
Member Author

Hi @willtebbutt, the version was already bumped, but I haven't released it just yet (was hoping to figure out the failures on master first). Do we merge this anyway and release it with the other fixes once they are done?

@willtebbutt
Copy link
Member

Ah okay, I hadn't realised we were in this situation. As a rule, we never leave an unreleased version of the package on master -- if a PR (with patch bump) is good enough for a release.

Could you please release the current version of master, then bump + release this? I grant you that it's annoying that there are failures on master, but unless you think that they're related to a PR that has recently been merged, I don't feel that they ought to disrupt the release cycle.

@simsurace
Copy link
Member Author

No the remaining failures are likely due to relying on some internals in Julia, and were introduced by the Julia 1.8 -> 1.9 update. I will do as you suggest.

@simsurace simsurace merged commit 9a2f7bb into master Nov 20, 2023
@simsurace simsurace deleted the rm-mahalanobis branch November 20, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants