Bump compat to include Functors v0.5 #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, could you bump the package version? |
limits compat to Flux v0.13 & v0.14
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
======================================
Coverage 0.28% 0.28%
======================================
Files 52 52
Lines 1421 1421
======================================
Hits 4 4
Misses 1417 1417 ☔ View full report in Codecov by Sentry. |
|
Added another change so the docs build with this PR ...before bumping the package version, what's the status of #564? It'd be nice if there weren't a bunch of "failed" checks before merging |
theogf
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #562, which is inactive.
Proposed changes
Bump compat to include Functors v0.5.
Breaking changes
Potentially breaks @functor, TBD.