-
Notifications
You must be signed in to change notification settings - Fork 36
Add NeuralNetOneKernel #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am not sure about the name. The "one" should imply that it is a single parameter kernel function. |
I think the name is extremly confusing... It sounds like it's a deep kernel (neural net transform on the inputs) but it's not. Is it really a necessary kernel? |
@theogf http://www.gaussianprocess.org/gpml/chapters/RW4.pdf pg 90 talks about how it came about. |
@theogf I found the significance of this kernel in Andrew Gordon's thesis and the GPML book itself.
We get such a kernel by assuming a single hidden layer neural network with infinite units. |
@theogf @devmotion Do you suggest any other changes? Or, can this be merged? |
IMO we should wait for (at least some of) the kernelmatrix changes. This PR seems to add many methods related to kernelmatrix, so I think by postponing it slightly we might be able to make it compatible with the kernelmatrix and kappa refactoring. |
@devmotion @theogf @willtebbutt Can this be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broadly looks good, and is fine to be merged, but it's won't currently be efficient for kernelmatrix
for multi-dimensional inputs. @sharanry if you could open an issue about this for multi-dimensional inputs, that would be very helpful, just so that we don't forget about it.
edit: looks like the tests for the Weiner kernel have appeared in this PR somehow. If you could remove before merging, that would be very helpful.
Issue #44
Neural network kernel function with a single parameter for the distance measure. The kernel function is parameterized as:
References