Skip to content

Added VecOfVecs and RowVecs #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 22, 2020
Merged

Added VecOfVecs and RowVecs #89

merged 8 commits into from
Apr 22, 2020

Conversation

theogf
Copy link
Member

@theogf theogf commented Apr 22, 2020

Adding RowVecs and an abstract type VecOfVecs for easier dispatch

willtebbutt
willtebbutt reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need an extra type. A helper function would be a good idea though.

willtebbutt
willtebbutt reviewed Apr 22, 2020
View reviewed changes
willtebbutt
willtebbutt reviewed Apr 22, 2020
View reviewed changes
willtebbutt
willtebbutt reviewed Apr 22, 2020
View reviewed changes
willtebbutt
willtebbutt reviewed Apr 22, 2020
View reviewed changes
willtebbutt
willtebbutt reviewed Apr 22, 2020
View reviewed changes
theogf and others added 2 commits April 22, 2020 17:19
devmotion
devmotion reviewed Apr 22, 2020
View reviewed changes
devmotion
devmotion reviewed Apr 22, 2020
View reviewed changes
willtebbutt
willtebbutt approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for merge once tests pass. Nice work!

@theogf theogf merged commit d52def6 into JuliaGaussianProcesses:master Apr 22, 2020
@devmotion
Copy link
Member

Nice!

@theogf theogf deleted the VecVecs branch April 22, 2020 16:20
@theogf theogf mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion left review comments

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theogf @devmotion @willtebbutt