Move to AbstractVector #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Théo Galy-Fajou <[email protected]>
Co-Authored-By: Théo Galy-Fajou <[email protected]>
willtebbutt
commented
Apr 25, 2020
Co-Authored-By: Théo Galy-Fajou <[email protected]>
Co-Authored-By: Théo Galy-Fajou <[email protected]>
devmotion
reviewed
Apr 25, 2020
Co-Authored-By: David Widmann <[email protected]>
Co-Authored-By: David Widmann <[email protected]>
|
All comments addressed, ready for a second round of reviewing @devmotion @theogf |
devmotion
reviewed
Apr 26, 2020
devmotion
reviewed
Apr 26, 2020
devmotion
reviewed
Apr 26, 2020
Co-Authored-By: David Widmann <[email protected]>
Co-Authored-By: David Widmann <[email protected]>
Co-Authored-By: David Widmann <[email protected]>
|
Thanks for the review @devmotion |
theogf
reviewed
Apr 26, 2020
|
Thanks @theogf -- let me know if there's anything else that changing. |
|
I think that's all for me! We can improve the coverage with more tests later |
devmotion
reviewed
Apr 26, 2020
|
LGTM ! |
devmotion
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #43 .
In the process of refactoring, it became necessary to also address #94 as this turned out to be blocking.
Other notable changes:
Transforminterface needed to change because the type of the input no longer determines whether you're operating on a single data point, or mapping across an entire data set. Consequentlyapplythis PR removesapplyin favour of evaluating the transform (transform a single data point) andmap(t, x)to apply a transform over each element of a data set efficiently.One thing I did that I should probably have opened an issue about is stop constraining the parameters of
ARDTransformandScaleTransformto be greater than zero as it's not a requirement of these transformations that you do so. I'm happy to revert the change in this PR and open an issue to discuss further if anyone objects strongly to this particular change.