fix haskey(g, :v1, :v2) for nonexistent vertices #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`arrange()` will fail for nonexistent vertices, so check that both vertices exist first. Add doctests for both forms of `haskey()`.
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 217 217
=========================================
Hits 217 217
Continue to review full report at Codecov.
|
|
Great! Thanks!! |
|
Oops, forgot to merge sorry! |
|
Do you need a new release? |
|
It'd be nice, then I can remove the workarounds in my own code.
From: bramtayl <[email protected]>
Sent: Thursday, February 18, 2021 10:41 AM
To: JuliaGraphs/MetaGraphsNext.jl <[email protected]>
Cc: Stuhl, Benjamin K. (Assoc) <[email protected]>; Author <[email protected]>
Subject: Re: [JuliaGraphs/MetaGraphsNext.jl] fix haskey(g, :v1, :v2) for nonexistent vertices (#12)
Do you need a new release?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQRGBUDKQIWG3BLK3KD3QMLS7VGJBANCNFSM4VTOFZJA>.
|
|
Ok! JuliaRegistries/General#30379 How do you like the package? |
|
I found it quite useful. I added another helper (beyond the `label_of()` that is also available in the new release) to make it easier to go between `LightGraphs.jl` and `MetaGraphsNext.jl`:
```julia
# map Edge to pair of labels
_labels_of(g::MetaGraph, e::Edge) = _label_of(g, e.src), _label_of(g, e.dst)
```
From: bramtayl <[email protected]>
Sent: Thursday, February 18, 2021 1:12 PM
To: JuliaGraphs/MetaGraphsNext.jl <[email protected]>
Cc: Stuhl, Benjamin K. (Assoc) <[email protected]>; Author <[email protected]>
Subject: Re: [JuliaGraphs/MetaGraphsNext.jl] fix haskey(g, :v1, :v2) for nonexistent vertices (#12)
Ok! JuliaRegistries/General#30379<JuliaRegistries/General#30379> How do you like the package?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQRGBUFVIFE72W23F2LDAITS7VYBNANCNFSM4VTOFZJA>.
|
|
I've had to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrange()will fail for nonexistent vertices, so check that bothvertices exist first. Add doctests for both forms of
haskey().