-
Notifications
You must be signed in to change notification settings - Fork 21
Add data-free methods for add_vertex!
and add_edge!
#48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On second thought this might be confusing, since |
Co-authored-by: Guillaume Dalle <[email protected]>
Could you maybe add some small tests? |
I added some tests now. I didn't add them to the tutorials, partly because I'm not familiar with the tooling there, partly because this seems not sufficiently important to include in a tutorial. |
I agree :) Could you maybe just put these tests in a separate file, like |
Sure: done. |
I fixed the constructors because your tests used the old version, don't forget to run the tests locally before asking CI to do the same 😉 we should be good to merge once they pass |
I've been shamelessly writing this entirely on Github's editor - so nothing checked locally :D. Anyway, more formatting issues finally made me download it locally to run JuliaFormatter; tests now also pass locally. |
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 92.72% 92.83% +0.10%
==========================================
Files 7 7
Lines 275 279 +4
==========================================
+ Hits 255 259 +4
Misses 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Following discussion with @gdalle on Slack, here's a suggestion to have data-free versions of
add_vertex!
andadd_edge!
if the corresponding data-types areNothing
.@gdalle mentioned that this could potentially be for any union type, but I wasn't completely clear on the implications of that. This was intended as the case where e.g.,
VertexData = Union{T, Nothing} where T
? Should we add that?