Add code_for #7
Add code_for #7
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 191 193 +2
=========================================
+ Hits 191 193 +2
Continue to review full report at Codecov.
|
| julia> meta[:a] = nothing | ||
|
|
||
| julia> code_for(meta, :a) | ||
| 1 |
There was a problem hiding this comment.
I don't understand what this is supposed to do. Why does this return 1?
There was a problem hiding this comment.
Because vertex :a is at vertex number 1. Does that make sense? Could I update the docs to make it more clear?
There was a problem hiding this comment.
Where did you add the vertex? Did it automatically get added on the setindex call on L338?
There was a problem hiding this comment.
Ok, well I guess I'll merge this. Let me know if I should add anything to the docs to clarify that vertices get automatically added.
There was a problem hiding this comment.
I think it's best if it were documented. Implicit mutation of a graph is a footgun.
Thought this might be useful to have. Similar to the CameronBieganek's
Vfunction.