-
Notifications
You must be signed in to change notification settings - Fork 2
Fix CI and add some docs #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI and add some docs #2
Conversation
Also, I've taken |
I made changes to that effect locally. I'll push to master and then we can address the probable merge conflict. |
Sounds good! |
I've pushed. Let me know when this is ready. |
I have some more ideas, but this PR is big enough as it is. So let's review this PR first, and I can make more changes in the next PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge?
EDIT: needs a dependency on Random
. Mind adding that here in the PR?
I forgot to add that when I changed master to support integer matrices.
Yeah good to merge once CI is green. One sec, I'll add the dep on Random. |
Is it a direct dep, or a test-only dep? |
Direct, should also add a |
Done and done. |
Done. Yeah it's definitely not performance critical. |
No description provided.