Skip to content

Fix CI and add some docs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Fix CI and add some docs #2

merged 2 commits into from
Jan 20, 2021

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member Author

Also, I've taken :StrideArrays out of the default list of libs, since the matmul in StrideArrays has been moved to Octavian.

@chriselrod
Copy link
Collaborator

Also, I've taken :StrideArrays out of the default list of libs, since the matmul in StrideArrays has been moved to Octavian.

I made changes to that effect locally. I'll push to master and then we can address the probable merge conflict.

@DilumAluthge
Copy link
Member Author

Also, I've taken :StrideArrays out of the default list of libs, since the matmul in StrideArrays has been moved to Octavian.

I made changes to that effect locally. I'll push to master and then we can address the probable merge conflict.

Sounds good!

@chriselrod
Copy link
Collaborator

Also, I've taken :StrideArrays out of the default list of libs, since the matmul in StrideArrays has been moved to Octavian.

I made changes to that effect locally. I'll push to master and then we can address the probable merge conflict.

Sounds good!

I've pushed. Let me know when this is ready.

@DilumAluthge DilumAluthge marked this pull request as ready for review January 20, 2021 17:22
@DilumAluthge
Copy link
Member Author

I have some more ideas, but this PR is big enough as it is. So let's review this PR first, and I can make more changes in the next PR.

Copy link
Collaborator

@chriselrod chriselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge?

EDIT: needs a dependency on Random. Mind adding that here in the PR?
I forgot to add that when I changed master to support integer matrices.

@DilumAluthge
Copy link
Member Author

Yeah good to merge once CI is green. One sec, I'll add the dep on Random.

@DilumAluthge
Copy link
Member Author

Is it a direct dep, or a test-only dep?

@chriselrod
Copy link
Collaborator

chriselrod commented Jan 20, 2021

Is it a direct dep, or a test-only dep?

Direct, should also add a using Random in src/BLASBenchmarks.jl.

@DilumAluthge
Copy link
Member Author

Done and done.

@DilumAluthge
Copy link
Member Author

Done. Yeah it's definitely not performance critical.

@chriselrod chriselrod merged commit 01f08e5 into JuliaLinearAlgebra:master Jan 20, 2021
@DilumAluthge DilumAluthge deleted the dpa/fix-ci branch January 20, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants