-
Notifications
You must be signed in to change notification settings - Fork 14
WIP: BandedBlockBandedMatrix can parameterize storage #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: BandedBlockBandedMatrix can parameterize storage #12
Conversation
But no tests for anything but PseudoBlockMatrix yet.
@dlfivefifty, the parameterization is pretty much done. I'll rebase on master once master passes on Travis. It can be tested by susbtituting I noticed that "test_broadcasting.jl" is not in "runtests.jl". Just putting it out there if it got lost at some point. |
Whoops, that’s an oversight |
I merged the changes to master back here, and tests should pass when on BlockArrays and BandedMatrices master. |
I've added an example using SharedArrays for building matrices. (CLArrays.jl hasn't been updated to 1.0 and I don't have access to a CUDA device.) The current SharedArrays code is much slower than the Serial one, but this is perhaps because I'm not specifying |
Now that I've merged (and squashed) the changes introduced here, this PR probably needs to be rebased. |
But no tests for anything but PseudoBlockMatrix yet.