Skip to content

WIP: BandedBlockBandedMatrix can parameterize storage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mdavezac
Copy link
Contributor

But no tests for anything but PseudoBlockMatrix yet.

But no tests for anything but PseudoBlockMatrix yet.
@mdavezac
Copy link
Contributor Author

mdavezac commented Sep 21, 2018

@dlfivefifty, the parameterization is pretty much done. I'll rebase on master once master passes on Travis. It can be tested by susbtituting PseudoBlockArray with BlockArray.

I noticed that "test_broadcasting.jl" is not in "runtests.jl". Just putting it out there if it got lost at some point.

@dlfivefifty
Copy link
Member

I noticed that "test_broadcasting.jl" is not in "runtests.jl". Just putting it out there if it got lost at some point.

Whoops, that’s an oversight

@dlfivefifty
Copy link
Member

I merged the changes to master back here, and tests should pass when on BlockArrays and BandedMatrices master.

@dlfivefifty
Copy link
Member

I've added an example using SharedArrays for building matrices. (CLArrays.jl hasn't been updated to 1.0 and I don't have access to a CUDA device.) The current SharedArrays code is much slower than the Serial one, but this is perhaps because I'm not specifying localindices.

@dlfivefifty
Copy link
Member

Now that I've merged (and squashed) the changes introduced here, this PR probably needs to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants