Skip to content

Support block banded cholesky #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Support block banded cholesky #130

merged 3 commits into from
Jun 16, 2022

Conversation

dlfivefifty
Copy link
Member

No description provided.

@dlfivefifty
Copy link
Member Author

@TSGut @MikaelSlevinsky This might be useful especially for 2D stuff. Should be fairly straightforward to get it working adaptively as well.

FYI for 2D finite-difference matrix it roughly matches the speed of UMFPack which I think is a "success":

julia> @time cholesky(Symmetric(Δ));
  0.360270 seconds (359.21 k allocations: 204.490 MiB)

julia> @time cholesky(sparse(Δ));
  0.379772 seconds (5.49 k allocations: 88.902 MiB)

@dlfivefifty
Copy link
Member Author

Actually... this has a different complexity than UMF pack so when n becomes large UMFPack is still much faster...

@dlfivefifty
Copy link
Member Author

But it would be pretty easy to add hierarchical multi-threading combined with the rank-update formula....but adding support for multi-threading should be done to all BlockArrays.jl (and dependencies) linalg routines.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #130 (ebca6dc) into master (a77af6f) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   87.00%   86.90%   -0.11%     
==========================================
  Files          10       10              
  Lines        1185     1191       +6     
==========================================
+ Hits         1031     1035       +4     
- Misses        154      156       +2     
Impacted Files Coverage Δ
src/BlockBandedMatrices.jl 0.00% <ø> (ø)
src/interfaceimpl.jl 96.05% <ø> (-2.54%) ⬇️
src/linalg.jl 83.14% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77af6f...ebca6dc. Read the comment docs.

@dlfivefifty dlfivefifty merged commit 5344b37 into master Jun 16, 2022
@dlfivefifty dlfivefifty deleted the dl/cholesky branch June 16, 2022 15:41
@MikaelSlevinsky
Copy link
Member

Should I retract my rocket?

@dlfivefifty
Copy link
Member Author

Probably... at least until we add multithreading. (Actually that might be a bigger part of why UMFPack seems to have better complexity.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants