Skip to content

Don't import maybetail #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 8, 2022

Base._maybetail has been renamed to Base.safe_tail on julia nightly. Since this is an internal function, it's best if we define it ourselves int his package.

Edit: It appears that this function isn't used at all in this package, so I've removed it for now.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #132 (0b39a01) into master (b23c5d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          10       10           
  Lines        1191     1191           
=======================================
  Hits         1035     1035           
  Misses        156      156           
Impacted Files Coverage Δ
src/BlockBandedMatrices.jl 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jishnub jishnub changed the title move maybetail to this package Don't import maybetail Aug 8, 2022
@dlfivefifty dlfivefifty merged commit 6b2424c into JuliaLinearAlgebra:master Aug 8, 2022
@jishnub jishnub deleted the maybetail branch January 12, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants