Skip to content

don't import libblas #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 8, 2022

BLAS.libblas is imported into this package, but it's not used anywhere. This leads to a failure on Julia nightly, as libblas has been removed.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #133 (40fa95d) into master (b23c5d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          10       10           
  Lines        1191     1191           
=======================================
  Hits         1035     1035           
  Misses        156      156           
Impacted Files Coverage Δ
src/BlockBandedMatrices.jl 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlfivefifty dlfivefifty merged commit 604628d into JuliaLinearAlgebra:master Aug 8, 2022
@jishnub jishnub deleted the libblas branch January 12, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants