Skip to content

Remove explicit test on v1.8 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 14, 2022

This is unnecessary now as v1 points to v1.8. Also, avoid duplicate tests on push+PR.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 86.90% // Head: 86.81% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (55e7020) compared to base (f19b903).
Patch has no changes to coverable lines.

❗ Current head 55e7020 differs from pull request most recent head 62a9177. Consider uploading reports for the commit 62a9177 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   86.90%   86.81%   -0.09%     
==========================================
  Files          10       10              
  Lines        1191     1191              
==========================================
- Hits         1035     1034       -1     
- Misses        156      157       +1     
Impacted Files Coverage Δ
src/broadcast.jl 78.65% <0.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Member Author

jishnub commented Oct 14, 2022

Coverage failure points to this line:
https://github.com/JuliaMatrices/BlockBandedMatrices.jl/blob/55e7020f12ef3778603adb3191ef72e931c52727/src/broadcast.jl#L14
Is this not being tested? Perhaps this is spurious, as the commit head is incorrect for some strange reason.

@dlfivefifty
Copy link
Member

I think don't worry about coverage failure when its on the level of "noise"

@dlfivefifty dlfivefifty merged commit 6c36f2c into JuliaLinearAlgebra:master Oct 14, 2022
@jishnub jishnub deleted the CIaction branch January 12, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants