Skip to content

typos #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spaette opened this issue Mar 4, 2023 · 1 comment · Fixed by #106
Closed

typos #103

spaette opened this issue Mar 4, 2023 · 1 comment · Fixed by #106

Comments

@spaette
Copy link

spaette commented Mar 4, 2023

Rectangular
Specifies
columns
don't
entries
stability

the src/svd.jl content only the vectors us to the number of rows and columns might be rewritten

$ ed -s GenericLinearAlgebra.jl/test/rectfullpacked.jl <<<'5p'
@testset "Rectuangular Full Pack Format" begin
$ ed -s GenericLinearAlgebra.jl/src/svd.jl <<<'566p'
- `full`: Sepcifies if all the left and right singular vectors be returned or if only the vectors us to the number of rows and columns of the input matrix `A` should be returned (the default).
$ ed -s GenericLinearAlgebra.jl/src/lapack.jl <<<'673p'
                            "the number of columne in the output matrices are $mm, but should be $n",
$ ed -s GenericLinearAlgebra.jl/src/eigenGeneral.jl <<<'251p'
        # values doen't matter in this case but variables should be initialized
$ ed -s GenericLinearAlgebra.jl/src/svd.jl <<<'607p'
    # The location of the super/sub-diagonal of the bidiagonal matrix depends on the aspect ratio of the input. For tall and square matrices, the bidiagonal matrix is upper whereas it is lower for wide input matrices as illustrated below. The 'O' entried indicate orthogonal (unitary) matrices.
$ ed -s GenericLinearAlgebra.jl/test/qr.jl <<<'22p'
        else # For type stbility getindex(,Tuple{:R}) throw when the output is trapezoid
$ 
@spaette
Copy link
Author

spaette commented Mar 6, 2023

@andreasnoack

Have you suggestions on a rewrite of src/svd.jl line 566?

andreasnoack added a commit that referenced this issue Mar 7, 2023
andreasnoack added a commit that referenced this issue Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant