Skip to content

Refactor code to avoid out of bounds operation after deflation #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023

Conversation

andreasnoack
Copy link
Member

Closes #121

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8414b44) 95.94% compared to head (4e1dc1d) 95.95%.

❗ Current head 4e1dc1d differs from pull request most recent head a3d7c17. Consider uploading reports for the commit a3d7c17 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   95.94%   95.95%           
=======================================
  Files          11       11           
  Lines        1626     1630    +4     
=======================================
+ Hits         1560     1564    +4     
  Misses         66       66           
Impacted Files Coverage Δ
src/svd.jl 97.38% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andreasnoack andreasnoack added this pull request to the merge queue May 4, 2023
@andreasnoack andreasnoack removed this pull request from the merge queue due to a manual request May 4, 2023
@andreasnoack andreasnoack merged commit edbe5df into master May 4, 2023
@andreasnoack andreasnoack deleted the an/issue121 branch May 4, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deflation breaks edge case
1 participant