Skip to content

Test if SVD problem is tall or wide based on uplo field instead #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

andreasnoack
Copy link
Member

istriu function since it's misleading for matrices where one of the
dimension sizes is just one. Closes #79

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #80 (ec947a7) into master (68b746b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files          11       11           
  Lines        1671     1671           
=======================================
  Hits         1228     1228           
  Misses        443      443           
Impacted Files Coverage Δ
src/svd.jl 80.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b746b...ec947a7. Read the comment docs.

istriu function since it's misleading for matrices where one of the
dimnension sizes is just one.
@andreasnoack andreasnoack merged commit 4a71f79 into master Sep 16, 2021
@andreasnoack andreasnoack deleted the an/issue79 branch September 16, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoundsError while calling svd
1 participant