Skip to content

Load LBT to call LAPACK functions #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Load LBT to call LAPACK functions #85

merged 3 commits into from
Mar 2, 2022

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Mar 2, 2022

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #85 (2d68cc6) into master (ca1a1ef) will increase coverage by 0.44%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   73.48%   73.92%   +0.44%     
==========================================
  Files          11       10       -1     
  Lines        1671     1542     -129     
==========================================
- Hits         1228     1140      -88     
+ Misses        443      402      -41     
Impacted Files Coverage Δ
src/lapack.jl 54.85% <76.47%> (+0.40%) ⬆️
src/householder.jl 78.40% <0.00%> (-1.60%) ⬇️
src/tridiag.jl 85.71% <0.00%> (-0.96%) ⬇️
src/eigenSelfAdjoint.jl 92.48% <0.00%> (-0.61%) ⬇️
src/qr.jl 98.24% <0.00%> (-0.20%) ⬇️
src/juliaBLAS.jl 24.82% <0.00%> (-0.04%) ⬇️
src/GenericLinearAlgebra.jl
src/eigenGeneral.jl 67.04% <0.00%> (+0.01%) ⬆️
src/svd.jl 81.09% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1a1ef...2d68cc6. Read the comment docs.

@ViralBShah ViralBShah merged commit 6b6e348 into master Mar 2, 2022
@@ -1,14 +1,15 @@
name = "GenericLinearAlgebra"
uuid = "14197337-ba66-59df-a3e3-ca00e7dcff7a"
version = "0.2.7"
version = "0.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make this a breaking release? The compat bound change should be sufficient, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case we need to make 0.2 releases for older versions of Julia, was my thought process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants