Skip to content

Use Aqua to enforce quality #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Use Aqua to enforce quality #115

merged 1 commit into from
Oct 13, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 13, 2022

Fixes some unbound args. There's still one issue that remains in https://github.com/JuliaMatrices/InfiniteLinearAlgebra.jl/blob/d8afdfeffee95ac47ce8454f16344723756f1203/src/blockbanded/blockbanded.jl#L62-L63
but there's an ambiguity for N=0 that needs to be fixed first. Once this is resolved, the unbound_args=false may be removed from the test.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 77.35% // Head: 77.35% // No change to project coverage 👍

Coverage data is based on head (34253d7) compared to base (b61183e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files          11       11           
  Lines        1307     1307           
=======================================
  Hits         1011     1011           
  Misses        296      296           
Impacted Files Coverage Δ
src/blockbanded/blockbanded.jl 94.87% <100.00%> (ø)
src/infql.jl 46.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty dlfivefifty merged commit 95cd26a into master Oct 13, 2022
@jishnub jishnub deleted the aqua branch October 13, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants