Skip to content

Adjust to !(AbstractQ <: AbstractMatrix) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

dkarrasch
Copy link
Member

This makes the package future proof for JuliaLang/julia#46196. Some of the tests look complicated which is due to the fact that Matrix(Q) doesn't work.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 77.31% // Head: 78.10% // Increases project coverage by +0.78% 🎉

Coverage data is based on head (901c247) compared to base (90002ca).
Patch coverage: 70.58% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   77.31%   78.10%   +0.78%     
==========================================
  Files          11       11              
  Lines        1305     1306       +1     
==========================================
+ Hits         1009     1020      +11     
+ Misses        296      286      -10     
Impacted Files Coverage Δ
src/blockbanded/blockbanded.jl 94.87% <ø> (ø)
src/infql.jl 46.51% <42.85%> (ø)
src/InfiniteLinearAlgebra.jl 90.90% <50.00%> (+2.67%) ⬆️
src/banded/hessenbergq.jl 71.84% <66.66%> (+9.70%) ⬆️
src/banded/infbanded.jl 81.60% <66.66%> (ø)
src/banded/infqltoeplitz.jl 69.16% <85.71%> (-0.59%) ⬇️
src/infqr.jl 97.55% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkarrasch dkarrasch requested a review from dlfivefifty January 8, 2023 15:04
@dkarrasch
Copy link
Member Author

Gentle bump.

@dlfivefifty dlfivefifty merged commit 8b122c8 into master Feb 7, 2023
@dkarrasch dkarrasch deleted the dk/abstractq branch February 7, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants