Skip to content

Fix cholesky.L and bugs related to copy #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2024
Merged

Fix cholesky.L and bugs related to copy #174

merged 5 commits into from
May 18, 2024

Conversation

TSGut
Copy link
Contributor

@TSGut TSGut commented May 13, 2024

Fixes #173

The issue arises because adaptive Cholesky factors can't be copied.

Here's a minimal example of the error before fixing:

z = 10_000;
A = BandedMatrix(0 => -2*(0:∞)/z, 1 => Ones(∞), -1 => Ones(∞));
M = Symmetric(I-A)

chol = cholesky(M)
copy(chol.factors') # fails as described in the issue

I will also add tests to verify chol.L and copy() don't silently break in the future.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (b25d11f) to head (387a497).
Report is 9 commits behind head on master.

❗ Current head 387a497 differs from pull request most recent head 0ce1828. Consider uploading reports for the commit 0ce1828 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   81.53%   84.33%   +2.79%     
==========================================
  Files          10       11       +1     
  Lines        1381     1417      +36     
==========================================
+ Hits         1126     1195      +69     
+ Misses        255      222      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TSGut TSGut changed the title WIP: Fix cholesky.L and bugs related to copy Fix cholesky.L and bugs related to copy May 13, 2024
@TSGut
Copy link
Contributor Author

TSGut commented May 14, 2024

think this is ready for review or merge @dlfivefifty

not sure what the pre-job thing is that CI is stuck on, otherwise I would merge it myself

@TSGut
Copy link
Contributor Author

TSGut commented May 14, 2024

ok I think that addresses everything

@TSGut
Copy link
Contributor Author

TSGut commented May 18, 2024

Good to merge?

@dlfivefifty dlfivefifty merged commit 5857c95 into JuliaLinearAlgebra:master May 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cholesky .L doesn't work
2 participants