-
Notifications
You must be signed in to change notification settings - Fork 7
Fix cholesky.L and bugs related to copy #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 81.53% 84.33% +2.79%
==========================================
Files 10 11 +1
Lines 1381 1417 +36
==========================================
+ Hits 1126 1195 +69
+ Misses 255 222 -33 ☔ View full report in Codecov by Sentry. |
think this is ready for review or merge @dlfivefifty not sure what the pre-job thing is that CI is stuck on, otherwise I would merge it myself |
Co-authored-by: Sheehan Olver <[email protected]>
ok I think that addresses everything |
Good to merge? |
Fixes #173
The issue arises because adaptive Cholesky factors can't be copied.
Here's a minimal example of the error before fixing:
I will also add tests to verify
chol.L
andcopy()
don't silently break in the future.