Skip to content

Specialize Base.axes for [Composite/Adjoint/Transpose]Maps #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2021

Conversation

dkarrasch
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #164 (1cadef7) into master (e575b5f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          14       14           
  Lines        1061     1064    +3     
=======================================
+ Hits         1055     1058    +3     
  Misses          6        6           
Impacted Files Coverage Δ
src/LinearMaps.jl 97.75% <100.00%> (+0.02%) ⬆️
src/composition.jl 100.00% <100.00%> (ø)
src/transpose.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e575b5f...1cadef7. Read the comment docs.

@dkarrasch
Copy link
Member Author

@krcools Do you see any potential issue with this?

@krcools
Copy link
Contributor

krcools commented Nov 4, 2021

Thank you for including this also for CompositeMaps. I don't see any issue, apart from maybe we can also get this to work for TransposeMaps and AdjointMaps in a single release.

@dkarrasch
Copy link
Member Author

dkarrasch commented Nov 4, 2021

That's difficult to test though, because transpose and adjoint of WrappedMaps of AbstractMatrices are passed to the matrix, so we get a WrappedMap{Transpose{BlockMatrix}}, roughly speaking. Or, in other words, transpose and adjoint work out of the box for BlockMatrix-based LinearMaps.

EDIT: We can test that by re-wrapping into a WrappedMap.

@dkarrasch dkarrasch changed the title Specialize Base.axes for CompositeMaps Specialize Base.axes for [Composite/Adjoint/Transpose]Maps Nov 4, 2021
@dkarrasch dkarrasch merged commit e05375f into master Nov 4, 2021
@dkarrasch dkarrasch deleted the dk/composeaxes branch November 4, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants