Skip to content

Fix links to documentation #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Conversation

tknopp
Copy link
Contributor

@tknopp tknopp commented Jan 24, 2022

they were pointing to nowhere

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@7363170). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #167   +/-   ##
=========================================
  Coverage          ?   99.63%           
=========================================
  Files             ?       14           
  Lines             ?     1089           
  Branches          ?        0           
=========================================
  Hits              ?     1085           
  Misses            ?        4           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7363170...c304fd0. Read the comment docs.

@dkarrasch
Copy link
Member

Thanks. That got messed up when moving the package to JuliaLinearAlgebra. I assume now any reference to @Jutho's account is wrong, isn't it? I see more of those references in the CI/build status and code coverage in the README and in the doc's make.jl. Would you be able to fix them as well?

@tknopp
Copy link
Contributor Author

tknopp commented Jan 24, 2022

did not scroll further down :-)

@dkarrasch
Copy link
Member

... and the docs/make.jl file, please. In the deploydocs function, there is another /Jutho/LinearMaps.jl where Jutho needs to be replaced by JuliaLinearAlgebra.

@dkarrasch
Copy link
Member

I guess the documenter key needed an update. Let's see if it worked.

@dkarrasch dkarrasch closed this Jan 24, 2022
@dkarrasch dkarrasch reopened this Jan 24, 2022
@dkarrasch
Copy link
Member

Hm, the problem is that the documentation is not deployed because something is wrong with the deploy keys (though I tried to replace the keys with the new "owner" name JuliaLinearAlgebra). Does anybody know what adjustments need to be made after moving a repo? Maybe @ViralBShah knows (somebody who knows)?

@tknopp
Copy link
Contributor Author

tknopp commented Jan 24, 2022

Do you expect deploying to work on a PR?

@dkarrasch
Copy link
Member

I believe it used to deploy. We had a preview link to the new documentation in that box listing all the GHA steps. But you may be right. I could merge this and see what happens.

@dkarrasch dkarrasch merged commit 81b60b8 into JuliaLinearAlgebra:master Jan 24, 2022
@dkarrasch
Copy link
Member

Thanks for pushing me! 😝 Seems like it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants