Simplify multiple dispatch #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 98.62% 98.60% -0.03%
==========================================
Files 17 17
Lines 1381 1360 -21
==========================================
- Hits 1362 1341 -21
Misses 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes those type annotations that are never used in multiple dispatch. The common pattern of input types and output types (AbstractVector -> AbstractVecOrMat, AbstractMatrix -> AbstractMatrix) is consistent with
LinearAlgebra, and is checked for at themul!level. Afterwards, in_unsafe_mul!the consistency of input and output types is never checked again. What matters is only (a) which map type we use, (b) to which array type we apply the map. In the 5-arg case, it is clear thatmul!will only deliverNumbers as fourth and fifth argument. I believe this improves readability quite a bit. I have used the opportunity to (hopefully) clearify the docs even more.