Add Invalidations.yml #190
Conversation
|
Wow, thanks, what a service. Unfortunately, CI doesn't run on this. Besides the mentioned PRs above, do you have a case where one can see the output for a failed "invalidation test"? In the ones listed above, there is not much of visual output. |
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency. See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29
ranocha
changed the title
|
In SciML, we decided to skip CI for this (since we needed to update ~100 repos). I changed the commit message here to let CI run. |
Codecov ReportBase: 98.63% // Head: 99.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 98.63% 99.58% +0.94%
==========================================
Files 17 17
Lines 1396 1448 +52
==========================================
+ Hits 1377 1442 +65
+ Misses 19 6 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This is how it looks like when you create invalidations: ranocha/InvalidationsTest.jl#1 |
|
Ok, so it just triggers a fail, but no further information. |
|
In my experience, fixing invalidations is a quite manual process, so you also need to experiment locally. |
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.
See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29