Fix deprecations #109
Fix deprecations #109
Conversation
![femtocleaner[bot]](https://avatars.githubusercontent.com/in/4123?s=60&v=4){kind=small}
src/fixed.jl
Outdated
| @@ -10,8 +10,8 @@ end | |||
| Fixed{T, f}(x::AbstractChar) where {T,f} = throw(ArgumentError("Fixed cannot be constructed from a Char")) | |||
| Fixed{T, f}(x::Complex) where {T,f} = Fixed{T, f}(convert(real(typeof(x)), x)) | |||
| Fixed{T, f}(x::Base.TwicePrecision) where {T,f} = Fixed{T, f}(convert(Float64, x)) | |||
| Fixed{T,f}(x::Integer) where {T,f} = Fixed{T,f}(round(T, convert(widen1(T),x)<<f),0) | |||
| Fixed{T,f}(x::AbstractFloat) where {T,f} = Fixed{T,f}(round(T, trunc(widen1(T),x)<<f + rem(x,1)*(one(widen1(T))<<f)),0) | |||
| Fixed{T,f}(x::Integer) where {T,f} = Fixed{T,f}(round(T, digits=convert(widen1(T),x)<<f),0) | |||
There was a problem hiding this comment.
I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.
src/normed.jl
Outdated
| round(::Type{T}, x::Normed) where {T <: Integer} = round(T, reinterpret(x)/rawone(x)) | ||
| floor(::Type{T}, x::Normed) where {T <: Integer} = trunc(T, x) | ||
| ceil(::Type{T}, x::Normed) where {T <: Integer} = ceil(T, reinterpret(x)/rawone(x)) | ||
| trunc(::Type{T}, digits=x::Normed) where {T <: Integer} = convert(T, div(reinterpret(x), rawone(x))) |
There was a problem hiding this comment.
I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.
src/normed.jl
Outdated
| ceil(::Type{T}, x::Normed) where {T <: Integer} = ceil(T, reinterpret(x)/rawone(x)) | ||
| trunc(::Type{T}, digits=x::Normed) where {T <: Integer} = convert(T, div(reinterpret(x), rawone(x))) | ||
| round(::Type{T}, digits=x::Normed) where {T <: Integer} = round(T, digits=reinterpret(x)/rawone(x)) | ||
| floor(::Type{T}, digits=x::Normed) where {T <: Integer} = trunc(T, digits=x) |
There was a problem hiding this comment.
I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.
test/normed.jl
Outdated
| @test round(Int,x) == round(Int,xf) | ||
| @test floor(Int,x) == floor(Int,xf) | ||
| @test trunc(Int, digits=x) == trunc(Int, digits=xf) | ||
| @test round(Int, digits=x) == round(Int, digits=xf) |
There was a problem hiding this comment.
I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.
|
My code has been updated. I now view the world differently. |
femtocleaner
bot
force-pushed
the
fbot/deps
branch
from
652411a to
d3157a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 111 111
=====================================
Hits 111 111
Continue to review full report at Codecov.
|
I fixed a number of deprecations for you