Skip to content

Fix ambiguity test on Julia v1.6.0-DEV #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Sep 3, 2020

cf. JuliaLang/julia PR #36962

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #225 into master will increase coverage by 3.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   91.58%   95.19%   +3.61%     
==========================================
  Files           6        6              
  Lines         582      645      +63     
==========================================
+ Hits          533      614      +81     
+ Misses         49       31      -18     
Impacted Files Coverage Δ
src/precompile.jl 100.00% <0.00%> (ø)
src/utilities.jl 96.55% <0.00%> (+0.25%) ⬆️
src/normed.jl 93.54% <0.00%> (+1.32%) ⬆️
src/fixed.jl 97.94% <0.00%> (+2.49%) ⬆️
src/FixedPointNumbers.jl 95.61% <0.00%> (+7.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d7bbc...565523d. Read the comment docs.

@kimikage kimikage merged commit 595f7a7 into JuliaMath:master Sep 3, 2020
@kimikage kimikage deleted the ambiguity_test branch September 3, 2020 05:32
@johnnychen94
Copy link
Collaborator

FYI https://github.com/JuliaTesting/Aqua.jl can be used to automate this kind of meta quality test

@kimikage
Copy link
Collaborator Author

kimikage commented Sep 9, 2020

Yes. However, keeping up with the changes in the nightly build is generally a necessary task, and what Aqua can automate is quite limited.

FixedPointNumbers is a "solid" package at the root of the JuliaImages ecosystem, so I can't expect any quality improvement by Aqua (in fact, this package should pass its tests).

That said, from an assurance and traceability perspective, Aqua is helpful and I'm not opposed to its introduction.
Would you like to add the Aqua badge, or not?

@johnnychen94
Copy link
Collaborator

The major advantage of Aqua shows up when you have tens of packages under watch and when all of them are hitting similar issues like this.

In any case, we don't need to immediately use Aqua; it is more of a personal taste and depends on how much maintenance work you have.

@kimikage
Copy link
Collaborator Author

kimikage commented Sep 9, 2020

Further changes to the ambiguity computing may be made in the future due to latency regression and type intersection issues.

I would like to hold off on the decision to introduce Aqua until FixedPointNumbers v0.9.0 is ready for release. I have at least a couple of PRs to submit before the v0.9.0 release.

@kimikage
Copy link
Collaborator Author

kimikage commented Sep 9, 2020

Ah, it's been reverted.:sweat_smile: (julia#37484)

@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants