Skip to content

add doctest in unittest #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Conversation

johnnychen94
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files           6        6           
  Lines         677      677           
=======================================
  Hits          646      646           
  Misses         31       31           
Impacted Files Coverage Δ
src/FixedPointNumbers.jl 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b8a9c...248c4b9. Read the comment docs.

@kimikage
Copy link
Collaborator

kimikage commented Sep 14, 2020

I think this is a good change, but if we use Documenter, it might be a good idea to create a new document in the future. I have some performance tips for package developers.

Edit:
Also, I think it's enough to check the doctests on specific version and architecture.

@kimikage kimikage merged commit 4d0e46a into JuliaMath:master Sep 19, 2020
@johnnychen94 johnnychen94 deleted the jc/doctest branch September 19, 2020 11:59
@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants