Skip to content

Use GitHub Actions for unit testing on Arm arch. #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2020
Merged

Use GitHub Actions for unit testing on Arm arch. #238

merged 2 commits into from
Dec 19, 2020

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Dec 16, 2020 •
edited
Loading

The test runs on a docker container with QEMU.
This also updates TagBot.yml.

Closes #237

@codecov
Copy link

codecov bot commented Dec 16, 2020 •
edited
Loading

Codecov Report

Merging #238 (e933aeb) into master (1e14ce6) will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   96.46%   95.68%   -0.79%     
==========================================
  Files           6        6              
  Lines         736      742       +6     
==========================================
  Hits          710      710              
- Misses         26       32       +6
Impacted Files Coverage Δ
src/fixed.jl 96.89% <0.00%> (-1.22%) ⬇️
src/FixedPointNumbers.jl 95.75% <0.00%> (-0.95%) ⬇️
src/normed.jl 95.47% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e14ce6...e933aeb. Read the comment docs.

@kimikage kimikage force-pushed the arm_ci branch 7 times, most recently from 3289b2a to 0bf0aad Compare December 16, 2020 05:09
johnnychen94
johnnychen94 reviewed Dec 16, 2020
View reviewed changes
@kimikage kimikage force-pushed the arm_ci branch 2 times, most recently from 9c66e69 to a5f38d0 Compare December 16, 2020 05:35
johnnychen94
johnnychen94 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config file looks good to me. We might hit with some unrelated GA/docker issue. I'd suggest trying it again a few hours later or tomorrow.

.github/workflows/UnitTestArm.yml
strategy:
fail-fast: false
matrix:
julia-version: ['1.0', '1', 'nightly']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just 1 to save CI build time? I'm not sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since those tests are run in parallel, I do not think reducing the targets will have much of an effect on speeding up the total process.

@kimikage kimikage force-pushed the arm_ci branch 5 times, most recently from 2dc77ff to 13109c4 Compare December 16, 2020 07:00
@johnnychen94
Copy link
Collaborator

johnnychen94 commented Dec 16, 2020 •
edited
Loading

😱 the CI is unpredictable.

@kimikage kimikage force-pushed the arm_ci branch 6 times, most recently from a6efe98 to 9dbf745 Compare December 16, 2020 09:41
@johnnychen94

This comment has been minimized.

Sign in to view
@kimikage kimikage force-pushed the arm_ci branch 4 times, most recently from fc319ca to 1595164 Compare December 16, 2020 10:39
@kimikage kimikage force-pushed the arm_ci branch 2 times, most recently from a32eef2 to 84679bd Compare December 16, 2020 11:01
@kimikage

This comment has been minimized.

Sign in to view
@kimikage kimikage force-pushed the arm_ci branch 2 times, most recently from f7c76d7 to 084dece Compare December 16, 2020 12:00
@kimikage
Copy link
Collaborator Author

test (1.0, ... 27m 29s
test (1, ... 43m 18s
test (nightly, ... 26m 2s

Although I had expected it, it seems too slow. 😭
However, compared to Travis CI, GitHub Actions has a higher parallelism, so the total time does not seem to be drastically different.
Umm....

@kimikage
Use GitHub Actions for unit testing on Arm arch.
038d0f8 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
@kimikage kimikage marked this pull request as ready for review December 16, 2020 14:39
@kimikage kimikage force-pushed the arm_ci branch 4 times, most recently from 0873cc1 to ebfdda1 Compare December 17, 2020 03:56
@kimikage
Copy link
Collaborator Author

There is some room for improvement, but I'd like to try this out first.

Thank you, Travis CI, for all your support!

@kimikage kimikage merged commit fe2135d into JuliaMath:master Dec 19, 2020
@kimikage kimikage deleted the arm_ci branch December 19, 2020 02:56
@johnnychen94
Copy link
Collaborator

Is the slow CI time a container issue, or just FixedPointNumbers has bad performance in Arm?

@kimikage
Copy link
Collaborator Author

I think the speed depends on the CI environment. At least the Travis CI tests which ran on the Arm machine were 2-3 times faster per configuration (i.e. julia-version).

I don't have a fast Arm machine, though.

@kimikage kimikage mentioned this pull request Apr 30, 2024
Closed
38 tasks
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
3310c0c 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
c63a404 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
7b94e19 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
930d954 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
f0d1353 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
051cc2f 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
56edbf2 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@kimikage
Use GitHub Actions for unit testing on Arm arch. (JuliaMath#238)
3d371dc 
The test runs on a docker container with QEMU.
This also updates TagBot.yml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration of CI for ARM
2 participants
@kimikage @johnnychen94