Skip to content

Warn, not error, on precompile failures #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

timholy
Copy link
Member

@timholy timholy commented Mar 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #242 (faf7e9c) into master (39e7d9b) will decrease coverage by 0.95%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   95.57%   94.61%   -0.96%     
==========================================
  Files           6        6              
  Lines         746      743       -3     
==========================================
- Hits          713      703      -10     
- Misses         33       40       +7     
Impacted Files Coverage Δ
src/precompile.jl 51.85% <29.41%> (-48.15%) ⬇️
src/utilities.jl 96.29% <0.00%> (-0.26%) ⬇️
src/normed.jl 95.90% <0.00%> (+0.43%) ⬆️
src/FixedPointNumbers.jl 96.38% <0.00%> (+0.94%) ⬆️
src/fixed.jl 98.11% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e7d9b...faf7e9c. Read the comment docs.

@kimikage
Copy link
Collaborator

kimikage commented Mar 4, 2021

@kimikage
Copy link
Collaborator

I'll leave this open until the next release is ready or the new style in SnoopCompile is settled.

@kimikage kimikage marked this pull request as draft April 27, 2021 11:07
@kimikage kimikage closed this Aug 3, 2021
@kimikage kimikage deleted the teh/warnpcfail branch April 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants