Work around rounding errors in nightly test #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 96.25% 92.73% -3.52%
==========================================
Files 6 6
Lines 748 730 -18
==========================================
- Hits 720 677 -43
- Misses 28 53 +25
Continue to review full report at Codecov.
|
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This forces the `BigFloat`-->`Float16` conversion to go through `Float32` instead of `Float64`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the
BigFloat-->Float16conversion to go throughFloat32instead ofFloat64.:confused:The nightly build also seems to have inference issues. I am going to make a separate PR.
Closes #246