Skip to content

Add tests with Aqua.jl #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Add tests with Aqua.jl #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a00e237
Add tests with Aqua.jl
hyrodium Apr 13, 2024
23b861a
add Aqua badge
hyrodium Apr 13, 2024
de9153f
update Random.jl compat to support Julia v1.0
hyrodium Apr 13, 2024
68b9c21
update Documenter.jl compat to support Julia v1.0
hyrodium Apr 13, 2024
40c5e55
remove duplicated tests for ambiguities
hyrodium Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,22 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
FixedPointNumbersStatisticsExt = "Statistics"

[compat]
Aqua = "0.8"
Documenter = "0.27, 1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the test dependency on Documenter.jl by adding documentation with Documenter.jl I will open a PR for that later.

Random = "<0.0.1, 1"
StableRNGs = "1"
# Update this version specifier when Statistics.jl v1.11.2 is released.
# https://github.com/JuliaStats/Statistics.jl/issues/165
Statistics = "< 1.11.2"
Test = "1"
julia = "1"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Documenter", "StableRNGs", "Statistics", "Test"]
test = ["Aqua", "Documenter", "StableRNGs", "Statistics", "Test"]
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
[![Build Status][action-img]][action-url]
[![Build Status][pkgeval-img]][pkgeval-url]
[![coverage][codecov-img]][codecov-url]
[![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl)

This library implements fixed-point number types. A
[fixed-point number] represents a fractional, or
Expand Down
8 changes: 2 additions & 6 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
using FixedPointNumbers, Test
using FixedPointNumbers, Test, Aqua

if VERSION >= v"1.6.0-DEV.816" # JuliaLang/julia #36962 # FIXME
@test isempty(detect_ambiguities(FixedPointNumbers))
else
@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core))
end
Aqua.test_all(FixedPointNumbers)

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, that's right. Updated in 40c5e55. (Removing isempty(detect_ambiguities(FixedPointNumbers)) was my first motivation for this PR 😂)


if Sys.ARCH === :x86_64 || Sys.ARCH === :i686
using Documenter
Expand Down